• Caitlin Potter's avatar
    [parser] avoid complex for-loop desugaring when possible · 267115da
    Caitlin Potter authored
    let/const declarations in "standard" C-style for-loops have
    some complex desugaring to accommodate the case where loop
    loop variables may be captured. This slows down the baseline
    performance of for-loops with let variables.
    
    This change attempts to avoid this desugaring if it's known that
    the loop variable is not captured at any point. A side effect of
    this change is that let/const loop variables, when not captured
    within the loop body, are not necessarily shown in the debugger,
    similar to other stack-allocated vars.
    
    BUG=v8:4762, v8:5460
    R=marja@chromium.org, adamk@chromium.org, yangguo@chromium.org
    
    Change-Id: I8dbe545a12c086f675972bdba60c94998268311a
    Reviewed-on: https://chromium-review.googlesource.com/472247
    Commit-Queue: Caitlin Potter <caitp@igalia.com>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#44731}
    267115da
Name
Last commit
Last update
..
compiler Loading commit data...
es6 Loading commit data...
es8 Loading commit data...
harmony Loading commit data...
ignition Loading commit data...
regress Loading commit data...
wasm Loading commit data...
debug-allscopes-on-debugger.js Loading commit data...
debug-backtrace.js Loading commit data...
debug-break-inline.js Loading commit data...
debug-break-native.js Loading commit data...
debug-breakpoints.js Loading commit data...
debug-clearbreakpoint.js Loading commit data...
debug-compile-event.js Loading commit data...
debug-compile-optimized.js Loading commit data...
debug-conditional-breakpoints.js Loading commit data...
debug-constructor.js Loading commit data...
debug-enable-disable-breakpoints.js Loading commit data...
debug-eval-scope.js Loading commit data...
debug-evaluate-bool-constructor.js Loading commit data...
debug-evaluate-closure.js Loading commit data...
debug-evaluate-declaration.js Loading commit data...
debug-evaluate-locals-capturing.js Loading commit data...
debug-evaluate-locals-optimized-double.js Loading commit data...
debug-evaluate-locals-optimized.js Loading commit data...
debug-evaluate-locals.js Loading commit data...
debug-evaluate-modify-catch-block-scope.js Loading commit data...
debug-evaluate-modify-this.js Loading commit data...
debug-evaluate-nested-let.js Loading commit data...
debug-evaluate-no-side-effect-async.js Loading commit data...
debug-evaluate-no-side-effect-builtins-2.js Loading commit data...
debug-evaluate-no-side-effect-builtins.js Loading commit data...
debug-evaluate-no-side-effect-control.js Loading commit data...
debug-evaluate-no-side-effect-iife.js Loading commit data...
debug-evaluate-no-side-effect-ops.js Loading commit data...
debug-evaluate-no-side-effect.js Loading commit data...
debug-evaluate-shadowed-context-2.js Loading commit data...
debug-evaluate-shadowed-context.js Loading commit data...
debug-evaluate-with.js Loading commit data...
debug-evaluate.js Loading commit data...
debug-event-listener.js Loading commit data...
debug-exceptions.js Loading commit data...
debug-function-scopes.js Loading commit data...
debug-generator-break-on-stack.js Loading commit data...
debug-generator-break.js Loading commit data...
debug-liveedit-1.js Loading commit data...
debug-liveedit-2.js Loading commit data...
debug-liveedit-3.js Loading commit data...
debug-liveedit-4.js Loading commit data...
debug-liveedit-check-stack.js Loading commit data...
debug-liveedit-compile-error.js Loading commit data...
debug-liveedit-diff.js Loading commit data...
debug-liveedit-double-call.js Loading commit data...
debug-liveedit-exceptions.js Loading commit data...
debug-liveedit-literals.js Loading commit data...
debug-liveedit-newsource.js Loading commit data...
debug-liveedit-patch-positions-replace.js Loading commit data...
debug-liveedit-replace-code.js Loading commit data...
debug-liveedit-restart-frame.js Loading commit data...
debug-liveedit-stack-padding.js Loading commit data...
debug-liveedit-stepin.js Loading commit data...
debug-liveedit-utils.js Loading commit data...
debug-materialized.js Loading commit data...
debug-multiple-breakpoints.js Loading commit data...
debug-multiple-var-decl.js Loading commit data...
debug-negative-break-points.js Loading commit data...
debug-optimize.js Loading commit data...
debug-print.js Loading commit data...
debug-receiver.js Loading commit data...
debug-return-value.js Loading commit data...
debug-scopes-suspended-generators.js Loading commit data...
debug-scopes.js Loading commit data...
debug-script.js Loading commit data...
debug-set-variable-value.js Loading commit data...
debug-setbreakpoint.js Loading commit data...
debug-sourceinfo.js Loading commit data...
debug-stack-check-position.js Loading commit data...
debug-step-2.js Loading commit data...
debug-step-3.js Loading commit data...
debug-step-4.js Loading commit data...
debug-step-end-of-script.js Loading commit data...
debug-step-into-json.js Loading commit data...
debug-step-into-valueof.js Loading commit data...
debug-step-stub-callfunction.js Loading commit data...
debug-step-turbofan.js Loading commit data...
debug-step.js Loading commit data...
debug-stepin-accessor-ic.js Loading commit data...
debug-stepin-accessor.js Loading commit data...
debug-stepin-builtin-callback-opt.js Loading commit data...
debug-stepin-builtin-callback.js Loading commit data...
debug-stepin-builtin.js Loading commit data...
debug-stepin-call-function-stub.js Loading commit data...
debug-stepin-construct-call.js Loading commit data...
debug-stepin-constructor.js Loading commit data...
debug-stepin-foreach.js Loading commit data...
debug-stepin-function-call.js Loading commit data...
debug-stepin-property-function-call.js Loading commit data...
debug-stepnext-do-while.js Loading commit data...
debug-stepout-recursive-function.js Loading commit data...
debug-stepout-scope-part1.js Loading commit data...
debug-stepout-scope-part2.js Loading commit data...
debug-stepout-scope-part3.js Loading commit data...
debug-stepout-scope-part4.js Loading commit data...
debug-stepout-scope-part5.js Loading commit data...
debug-stepout-scope-part6.js Loading commit data...
debug-stepout-scope-part7.js Loading commit data...
debug-stepout-scope-part8.js Loading commit data...
debug-stepout-to-builtin.js Loading commit data...
for-in-opt.js Loading commit data...
function-source.js Loading commit data...
regress-3225.js Loading commit data...
regress-5207.js Loading commit data...