• Andreas Haas's avatar
    [wasm] Use modification scopes on module level and not function level · fd52adcb
    Andreas Haas authored
    During WebAssembly compilation and instantiation we entered a
    {CodeSpaceMemoryModificationScope} several times per function. This
    introduced significant overhead, see the referenced bug. With this CL
    we enter the {CodeSpaceMemoryModificationScope} on a per-module
    granularity and not on a function granularity. We enter now the
    following scopes:
    
    * one scope for the whole synchronous compilation;
    * one scope for each finishing step in asynchronous compilation (each
        step finishes multiple functions);
    * one scope for module instantiation, without the execution of the
      start function.
    
    Locally these changes reduced the overhead significantly.
    
    R=mstarzinger@chromium.org, titzer@chromium.org
    CC=clemensh@chromium.org
    
    Bug: chromium:787731
    Change-Id: I5c5694544a97f4c1e5a2a29da9a005d0ca7616bd
    Reviewed-on: https://chromium-review.googlesource.com/787851Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49618}
    fd52adcb
Name
Last commit
Last update
..
baseline Loading commit data...
OWNERS Loading commit data...
compilation-manager.cc Loading commit data...
compilation-manager.h Loading commit data...
decoder.h Loading commit data...
function-body-decoder-impl.h Loading commit data...
function-body-decoder.cc Loading commit data...
function-body-decoder.h Loading commit data...
leb-helper.h Loading commit data...
local-decl-encoder.cc Loading commit data...
local-decl-encoder.h Loading commit data...
memory-tracing.cc Loading commit data...
memory-tracing.h Loading commit data...
module-compiler.cc Loading commit data...
module-compiler.h Loading commit data...
module-decoder.cc Loading commit data...
module-decoder.h Loading commit data...
signature-map.cc Loading commit data...
signature-map.h Loading commit data...
streaming-decoder.cc Loading commit data...
streaming-decoder.h Loading commit data...
wasm-api.cc Loading commit data...
wasm-api.h Loading commit data...
wasm-code-specialization.cc Loading commit data...
wasm-code-specialization.h Loading commit data...
wasm-debug.cc Loading commit data...
wasm-external-refs.cc Loading commit data...
wasm-external-refs.h Loading commit data...
wasm-heap.cc Loading commit data...
wasm-heap.h Loading commit data...
wasm-interpreter.cc Loading commit data...
wasm-interpreter.h Loading commit data...
wasm-js.cc Loading commit data...
wasm-js.h Loading commit data...
wasm-limits.h Loading commit data...
wasm-memory.cc Loading commit data...
wasm-memory.h Loading commit data...
wasm-module-builder.cc Loading commit data...
wasm-module-builder.h Loading commit data...
wasm-module.cc Loading commit data...
wasm-module.h Loading commit data...
wasm-objects-inl.h Loading commit data...
wasm-objects.cc Loading commit data...
wasm-objects.h Loading commit data...
wasm-opcodes.cc Loading commit data...
wasm-opcodes.h Loading commit data...
wasm-result.cc Loading commit data...
wasm-result.h Loading commit data...
wasm-text.cc Loading commit data...
wasm-text.h Loading commit data...
wasm-value.h Loading commit data...