• Clemens Backes's avatar
    Reland "[flags] Predictable should not imply single-threaded" · 9ac562d5
    Clemens Backes authored
    This is a reland of 5fd38582. It adds
    back all recursive implications (via --single-threaded), such that we
    can remove them individually in follow-up CLs and watch the state of
    the predictable bot.
    
    Original change's description:
    > [flags] Predictable should not imply single-threaded
    >
    > The --predictable flag is often used to reproduce issues, and having it
    > imply --single-threaded can change decisions like which compiler(s) to
    > use. This is because --single-threaded is meant to be set by embedders
    > (hence we do our best to support single-threaded execution), whereas
    > --predictable is a testing-only flag which should not change semantics
    > too much. The fact that --predictable executes everything in a single
    > thread is already implied by the PredictablePlatform.
    >
    > R=ahaas@chromium.org, machenbach@chromium.org
    > CC=​jkummerow@chromium.org
    >
    > Change-Id: Ic174dd59dfdbd6aa1a410f983db05db26c944cd5
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919828
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#74822}
    
    Change-Id: I7a060826761781727870dd96fffc42ced4675e76
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933143
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74970}
    9ac562d5
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...