• Samuel Groß's avatar
    [base] Fix bugs in AllocateInternal on Fuchsia · 972e2265
    Samuel Groß authored
    This CL fixes two issues:
    
    1) When the specified vmar_offset was zero, the previous logic would
       incorrectly conclude that no target address was specified, and would
       potentially place the allocation elsewhere in memory, not at the
       desired address. This CL now passes both the target address and the
       VMAR base address to AllocateInternal, which can then correctly
       determine whether a target address was supplied.
    
    2) When the root_vmar was used and a hint specified, the previous logic
       would incorrectly use nullptr as base address of the root_vmar, which
       appears to be incorrect. The new logic now obtains the actual base
       (apparently 2MB) through zx_object_get_info during initialization.
    
    Bug: v8:10391
    Change-Id: Ia8215440a790b4a2a0c8d33f623d3ecb6a731a97
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3398506Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
    Commit-Queue: Samuel Groß <saelo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78693}
    972e2265
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...