• Eric Holk's avatar
    [wasm] set thread-in-wasm flag after converting arguments · 025e3ab1
    Eric Holk authored
    In JS to Wasm wrappers, arguments have to be converted from JavaScript's
    representation to Wasm's representation. Because of property accessors, this can
    result in JavaScript or even asm.js/Wasm code being run. We were previously
    setting this flag before doing the parameter conversions, and if these
    conversions triggered a Wasm property getter then we would try to set the flag
    twice.
    
    With this change, we wait until after all argument conversions are done to set
    the flag.
    
    Bug: chromium:769846
    
    R=bradnelson@chromium.org
    
    Change-Id: Ia4b56df45619dcad69f3750bb33cacfedcaeb5b2
    Reviewed-on: https://chromium-review.googlesource.com/693414
    Commit-Queue: Brad Nelson <bradnelson@chromium.org>
    Reviewed-by: 's avatarBrad Nelson <bradnelson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48244}
    025e3ab1
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...