• Dan Elphick's avatar
    [builtins] Fix Array.of crashes by setting length correctly · d5dca89b
    Dan Elphick authored
    Before we can set the length of the created array in CSA, first check
    that it's possible and will do what we want. I.e. check
    a) that the length is writable
    b) the backing store is not copy-on-write and
    c) the old length is not greater than the new length (as otherwise later
    insertion past the end could restore values from the original
    constructor).
    
    If not then fall back on Runtime::kSetProperty.
    
    Bug: chromium:804177
    Change-Id: Id0e452f9d160704bbd71e87a075ba4e3983729a7
    Reviewed-on: https://chromium-review.googlesource.com/880922
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50818}
    d5dca89b
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
d8_default.gyp Loading commit data...
d8_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...