• Michael Stanton's avatar
    Revert "[TurboFan] Remove maximum inlining levels check from inlining heuristics" · f585415a
    Michael Stanton authored
    This reverts commit ecd3a2ea.
    
    Reason for revert: Bug 779509, a crash with chrome.
    
    Original change's description:
    > [TurboFan] Remove maximum inlining levels check from inlining heuristics
    > 
    > We have a check on maximum number of levels that can be inlined. This
    > in some cases causes performance cliffs, when we cannot inline a small
    > function because it has exceeded the number of levels. This cl removes
    > that check. The intuition is that, having gone down several levels in
    > a particular line stopping inlining that chain and exploring a new
    > call site may not be beneficial.
    > 
    > Bug: v8:6871
    > Change-Id: I120056db38e78ce48dff010b6cf994259238582a
    > Reviewed-on: https://chromium-review.googlesource.com/741705
    > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#49009}
    
    TBR=mythria@chromium.org,bmeurer@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:6871
    Change-Id: I4766f911cb326c224af110be5c0dd7a44362a880
    Reviewed-on: https://chromium-review.googlesource.com/743785Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
    Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49037}
    f585415a
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
OWNERS Loading commit data...
debug-coverage.cc Loading commit data...
debug-coverage.h Loading commit data...
debug-evaluate.cc Loading commit data...
debug-evaluate.h Loading commit data...
debug-frames.cc Loading commit data...
debug-frames.h Loading commit data...
debug-interface.h Loading commit data...
debug-scope-iterator.cc Loading commit data...
debug-scope-iterator.h Loading commit data...
debug-scopes.cc Loading commit data...
debug-scopes.h Loading commit data...
debug-stack-trace-iterator.cc Loading commit data...
debug-stack-trace-iterator.h Loading commit data...
debug-type-profile.cc Loading commit data...
debug-type-profile.h Loading commit data...
debug.cc Loading commit data...
debug.h Loading commit data...
debug.js Loading commit data...
interface-types.h Loading commit data...
liveedit.cc Loading commit data...
liveedit.h Loading commit data...
liveedit.js Loading commit data...
mirrors.js Loading commit data...