• Clemens Backes's avatar
    [traphandler] Fix ProbeMemory on Mac release builds · 936debb5
    Clemens Backes authored
    For some reason, the "ret" instruction goes missing on Mac release
    builds, probably because the compiler decides to split the inline
    assembly block and move the "v8_probe_memory_continuation" block
    somewhere else. This CL fixes that by adding another explicit "ret" at
    the end of "ProbeMemory".
    
    Also, we remove the "v8_probe_memory_address" symbol (which is identical
    to just "ProbeMemory"), to prevent the compiler from splitting
    "ProbeMemory" and "v8_probe_memory_address".
    
    R=ahaas@chromium.org
    
    Bug: v8:11955
    Change-Id: I2e63b2db94206e329be214ab7b553ab502d6ecc2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071202Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76091}
    936debb5
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...