• Caitlin Potter's avatar
    [async-await] remove CSA_SLOW_ASSERT in AsyncGeneratorResolve · 9867aa3f
    Caitlin Potter authored
    The assertion was intended to verify that the function is only called
    at appropriate times (at a point when it was called both by by other builtins, and by desugarings added in the parser and during bytecode generation) --- However, it didn't account for the case where
    the wrapper Promise is resolved with another JSPromise with a
    non-callable "then" method. (Step 12 of
    https://tc39.github.io/ecma262/#sec-promise-resolve-functions):
    
    "If IsCallable(thenAction) is false, then
        Return FulfillPromise(promise, resolution)."
    
    It would be observable to verify this behaviour by loading the "then"
    value and asserting that it's non-callable, so instead the CSA_ASSERT
    is just removed and replaced with a comment explaining the appropriate
    use of the function.
    
    BUG=chromium:897436, v8:5855
    R=bmeurer@chromium.org
    
    Change-Id: Ib4b11abfe3339409b57ccfda9c3f75a34e0db532
    Reviewed-on: https://chromium-review.googlesource.com/c/1296909
    Commit-Queue: Caitlin Potter <caitp@igalia.com>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56916}
    9867aa3f
Name
Last commit
Last update
..
regress-173361.js Loading commit data...
regress-4658.js Loading commit data...
regress-4696.js Loading commit data...
regress-4755.js Loading commit data...
regress-4904.js Loading commit data...
regress-546967.js Loading commit data...
regress-6100.js Loading commit data...
regress-6322.js Loading commit data...
regress-771470.js Loading commit data...
regress-772649.js Loading commit data...
regress-897436.js Loading commit data...
regress-crbug-347528.js Loading commit data...
regress-crbug-571149.js Loading commit data...
regress-crbug-578038.js Loading commit data...
regress-crbug-621111.js Loading commit data...
regress-crbug-621496.js Loading commit data...
regress-typedarray-out-of-bounds.js Loading commit data...