• Georg Neis's avatar
    Optimize JSCallWithArrayLike with diamond speculation when probable arguments... · 90a24303
    Georg Neis authored
    Optimize JSCallWithArrayLike with diamond speculation when probable arguments list is empty literal array
    
    The JSCallWithArraylike can be replaced with a JSCall if its probable arguments list is empty literal array. This replacement will introduce a deoptimization check to make sure the length of arguments list is 0 at runtime.
    
    This CL change this optimization to a diamond speculation which may help avoid deoptimization once and keep the fast path. This change may benefit a following usecase,
    
    function calcMax(testArray) {
         Array.max = function(array) {
             return Math.max.apply(Math, array);
         };
    
         var result = [];
         for (var i = 0; i < testArray.length - 3; i++) {
             var positiveNumbers = [];
             for (var j = 0; j < 3; j++) {
                 if (testArray[i + j] > 0) {
                     positiveNumbers.push(testArray[i + j]);
                 }
             }
             result.push(Array.max(positiveNumbers));
         }
         return result;
     }
    
     testArray = [-1, 2, 3, -4, -5, -6, -7, -8, -9, 10];
    
     for (var i = 0; i < 1000000; i++) {
         calcMax(testArray);
     }
    
    Bug: v8:9974
    Change-Id: I595627e2fd937527350c8f8652d701c791b41dd3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2967757
    Commit-Queue: Georg Neis <neis@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75636}
    90a24303
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...