• Clemens Backes's avatar
    [inspector][test] Fail on non-zero return code · 26b0eb67
    Clemens Backes authored
    While writing a new test I realized that the test did not fail if
    running into a CHECK or UNREACHABLE *after* printing the last expected
    line.
    That is because both stderr and the exit status are ignored. This CL
    fixes that.
    
    This will uncover a lot of memory leaks, which I plan to address in
    follow-up CLs.
    
    R=machenbach@chromium.org
    CC=​szuend@chromium.org
    
    Bug: chromium:1142437, v8:11107
    Cq-Include-Trybots: luci.v8.try:v8_linux64_asan_rel_ng
    Cq-Include-Trybots: luci.v8.try:v8_mac64_asan_rel_ng
    Cq-Include-Trybots: luci.v8.try:v8_win64_asan_rel_ng
    Change-Id: I65f325abf102e063bb4f449353c47e94d84de652
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519567Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71006}
    26b0eb67
Name
Last commit
Last update
..
__init__.py Loading commit data...
base.py Loading commit data...
message.py Loading commit data...
mkgrokdump.py Loading commit data...
mozilla.py Loading commit data...
test262.py Loading commit data...
webkit.py Loading commit data...