• Benedikt Meurer's avatar
    [inspector] Fix `Runtime.setMaxCallStackSizeToCapture`. · 8f8d2fe4
    Benedikt Meurer authored
    This change fixes the implementation of the previously introduced API
    `Runtime.setMaxCallStackSizeToCapture` to work correctly and also apply
    (consistently) to stack traces captured by V8 when exceptions are
    thrown. It does so in a fully backwards compatible manner.
    
    This change thus makes the previous fix for catapult (which landed in
    http://crrev.com/c/3347789) effective, and therefore ensures that real
    world performance benchmarks aren't affected by the use of the `Runtime`
    domain in the catapult test framework.
    
    Note this is basically a reland of crrev.com/c/3361839, but without
    touching the stack traces for console messages (which led to the
    regressions in crbug/1283516, crbug/1283523, etc.).
    
    Fixed: chromium:1280831
    Bug: chromium:1283162, chromium:1278650, chromium:1258599
    Bug: chromium:1280803, chromium:1280832, chromium:1280818
    Doc: https://bit.ly/v8-cheaper-inspector-stack-traces
    Change-Id: I3dcec7b75d76ca267fac8bd6fcb2cda60d5e60dd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3364086Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78479}
    8f8d2fe4
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...