• Seth Brenith's avatar
    [v8windbg] Skip undefined types in Torque structs · 3a558456
    Seth Brenith authored
    The test cctest/test-v8windbg recently started failing because the
    v8windbg debugger extension is unable to read the "flags" field on a
    SharedFunctionInfo instance. This occurs because one of the bitfields
    within "flags" has type OSRCodeCacheStateOfSFI, which is only declared
    using an "opaque enum declaration":
    
      enum OSRCodeCacheStateOfSFI : uint8_t;
    
    When WinDbg fails in its attempt to look up that type, v8windbg responds
    by failing to construct anything at all for "flags". However, the other
    17 bitfields in "flags" can be represented successfully, so a more
    useful behavior is to just skip the one failed entry.
    
    Change-Id: I40630548d21499e49f0214da28260318a38d9360
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3653096Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#80615}
    3a558456
Name
Last commit
Last update
..
base Loading commit data...
src Loading commit data...
test Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...
README.md Loading commit data...
copy-prereqs.py Loading commit data...