• ishell's avatar
    [ic] Fix StoreIC_SlowSloppy/Strict builtins. · 8f2245bf
    ishell authored
    ... by using KeyedStoreIC_Slow builtin instead. The issue with hard-coded
    language mode is that the stub can be re-used through megamorphic stub cache for
    an IC with incompatible language mode. KeyedStoreIC_Slow already does the
    right thing - it decodes the language mode from the IC slot kind.
    
    This CL also fixes the code kinds of the slow IC handlers. The code kind of
    IC handlers is used only for checking that the handler was added to the right
    megamorphic stub cache, which expect the handlers' code kinds to be either
    Code::LOAD_IC or Code::STORE_IC.
    
    And the megamorphic builtins are just helper code stubs that are called from
    IC dispatchers, therefore they should have BUILTIN code kind. Same applies to
    the other stubs which are neither IC dispatchers nor handlers.
    
    BUG=v8:5917
    
    Review-Url: https://codereview.chromium.org/2677603004
    Cr-Commit-Position: refs/heads/master@{#42958}
    8f2245bf
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...