• Leszek Swirski's avatar
    Revert "Reland "Reland "Improve error messages for property access on null/undefined""" · 7ac7b72b
    Leszek Swirski authored
    This reverts commit 819c3ae2.
    
    Reason for revert: Sorry Patrick, still failing on some layout tests :( https://test-results.appspot.com/data/layout_results/mac-rel/726365/blink_web_tests%20%28retry%20shards%20with%20patch%29/layout-test-results/results.html
    
    Original change's description:
    > Reland "Reland "Improve error messages for property access on null/undefined""
    >
    > This is a reland of 8b18c5e6
    >
    > Original change's description:
    > > Reland "Improve error messages for property access on null/undefined"
    > >
    > > This is a reland of 24c626c1
    > >
    > > Original change's description:
    > > > Improve error messages for property access on null/undefined
    > > >
    > > > Only print the property name when accessing null/undefined if we can
    > > > convert it to a string without causing side effects.
    > > > If we can't, omit the property name in the error message.
    > > > This should avoid confusion when the key is an object with toString().
    > > > E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object
    > > > Object]' anymore, which was misleading since the property accessed would
    > > > be 'a', but we can't evaluate the key without side effects.
    > > >
    > > > Bug: v8:11365
    > > > Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211
    > > > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > > > Commit-Queue: Patrick Thier <pthier@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#75250}
    > >
    > > Bug: v8:11365
    > > Change-Id: Ie2312337f4f1915faa31528a728d90833d80dbd1
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979599
    > > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > > Commit-Queue: Patrick Thier <pthier@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#75571}
    >
    > Bug: v8:11365
    > Change-Id: I90360641ecd870bd93247aa6d91dfb0ad049cfb8
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008219
    > Auto-Submit: Patrick Thier <pthier@chromium.org>
    > Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#75604}
    
    Bug: v8:11365
    Change-Id: I7d7c0f201288384c2aa38a51418b582a64213ae0
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3013352
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#75626}
    7ac7b72b
Name
Last commit
Last update
..
benchmarks Loading commit data...
bigint Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...