• Michael Achenbach's avatar
    Revert "cppgc: Fix CTP for destruction" · 8ab11efb
    Michael Achenbach authored
    This reverts commit 5a6c7dee.
    
    Reason for revert: Speculative: Lots of Chrome crashes:
    https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Blink%20Linux/13353/overview
    
    Original change's description:
    > cppgc: Fix CTP for destruction
    >
    > This avoids a benign race in setting the raw pointer inside CTP
    > destructor by not emitting the write at all. The handle is destructed
    > which means that we only need to destroy any backing node but may
    > leave the handle untouched.
    >
    > Drive-by:
    > - Add a few more docs.
    > - Make Clear() thread-safe.
    > - Make assignment of a sentinel pointer thread-safe.
    > - Make assignment of a nullptr thread-safe.
    >
    > Bug: chromium:1242795
    > Change-Id: I0d9dafa31c298053e87ba1eb75f99fa6e33fa10b
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3114134
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Reviewed-by: Anton Bikineev <bikineev@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#76455}
    
    Bug: chromium:1242795
    Change-Id: Ia96d66f4908894091a4e498116d9568bd7b0e0a3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3114058
    Auto-Submit: Michael Achenbach <machenbach@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Owners-Override: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76482}
    8ab11efb
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...