• Sathya Gunasekaran's avatar
    [ast] Store correct source position on ThisExpression · 8a9e3f64
    Sathya Gunasekaran authored
    Previously, all ThisExpression's had kNoSourcePositions leading to
    incorrect error messages like this:
    
      ➜ d8 -e "function t() { for (const x of this) {} } t();"
      unnamed:1: TypeError: undefined is not a function
      function t() { for (const x of this) {} } t();
                ^
      TypeError: undefined is not a function
          at t (unnamed:1:11)
          at unnamed:1:43
    
    
    This patch allows creation of a ThisExpression with a source position,
    leading to a better error message:
    
      ➜ d8  -e "function t() { for (const x of this) {} } t();"
      unnamed:1: TypeError: this is not iterable
      function t() { for (const x of this) {} } t();
                                     ^
      TypeError: this is not iterable
          at t (unnamed:1:32)
          at unnamed:1:43
    
    
    This patch does not remove the existing cached version of
    ThisExpression and instead creates a new one when required.
    
    Bug: v8:6513
    Change-Id: Idee4fe8946a9b821d06ff4a5e7eaefe54874ec59
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2345226Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69300}
    8a9e3f64
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...