• Maya Lekova's avatar
    Revert "[ic] Fix handling of API properties with side effects" · ba6a1a7c
    Maya Lekova authored
    This reverts commit 0ce36e7d.
    
    Reason for revert: Speculative revert for a Chromium build breakage causing a blocked roll - https://bugs.chromium.org/p/v8/issues/detail?id=11761
    
    Original change's description:
    > [ic] Fix handling of API properties with side effects
    >
    > DebugEvaluate can evaluate expressions in side-effect-free mode, where
    > any operation that would cause observable side effects throws an
    > exception. Currently, when accessors are backed by callbacks, it's
    > possible that ICs call those accessors directly, bypassing the
    > side-effect checks. This CL introduces a bailouts to runtime in those
    > cases.
    >
    > Fixed: chromium:1201781
    > Also-By: ishell@chromium.org, pfaffe@chromium.org
    > Change-Id: Ie53bfb2bff7b3420f2b27091e8df6723382cf53c
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2857634
    > Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#74507}
    
    Change-Id: Ifb5c24682af29572591d436ab92b0304058e99af
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2891650
    Auto-Submit: Maya Lekova <mslekova@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#74515}
    ba6a1a7c
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
riscv64 Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
basic-block-profiler.cc Loading commit data...
basic-block-profiler.h Loading commit data...
code-tracer.h Loading commit data...
compilation-statistics.cc Loading commit data...
compilation-statistics.h Loading commit data...
disasm.h Loading commit data...
disassembler.cc Loading commit data...
disassembler.h Loading commit data...
eh-frame.cc Loading commit data...
eh-frame.h Loading commit data...
gdb-jit.cc Loading commit data...
gdb-jit.h Loading commit data...
objects-debug.cc Loading commit data...
objects-printer.cc Loading commit data...
perf-jit.cc Loading commit data...
perf-jit.h Loading commit data...
system-jit-metadata-win.h Loading commit data...
system-jit-win.cc Loading commit data...
system-jit-win.h Loading commit data...
unwinder.cc Loading commit data...
unwinder.h Loading commit data...
unwinding-info-win64.cc Loading commit data...
unwinding-info-win64.h Loading commit data...