• Benedikt Meurer's avatar
    [debug] Consistent Step-In behavior for generator functions. · 887bacac
    Benedikt Meurer authored
    This change addresses inconsistencies wrt. to stepping into generator
    functions and breaking on the implicit initial yield. The new behavior
    is the following:
    
     1. Stepping into a generator function doesn't trigger "generator
        stepping", but rather pauses right before the initial yield
        (assuming there a no non-simple parameters in between).
     2. When paused on the initial yield and stepping into or over, we also
        don't turn on "generator stepping" immediately, but rather return to
        the caller and only enter "generator stepping" on SuspendGenerator
        bytecodes that correspond to `yield`s or `await`s in the source
        code.
    
    This matches the stepping behavior of regular functions more closely and
    seems like a good compromise.
    
    Fixed: chromium:901814
    Change-Id: Ifc6c174011df1afea183e2c6ec21de27d72b17a7
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2949099
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75066}
    887bacac
Name
Last commit
Last update
..
console Loading commit data...
counters Loading commit data...
cpu-profiler Loading commit data...
debugger Loading commit data...
heap-profiler Loading commit data...
regress Loading commit data...
runtime Loading commit data...
runtime-call-stats Loading commit data...
sessions Loading commit data...
type-profiler Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
frontend-channel.h Loading commit data...
inspector-test.cc Loading commit data...
inspector.status Loading commit data...
isolate-data.cc Loading commit data...
isolate-data.h Loading commit data...
json-parse-expected.txt Loading commit data...
json-parse.js Loading commit data...
print-method-not-found-expected.txt Loading commit data...
print-method-not-found.js Loading commit data...
protocol-test.js Loading commit data...
task-runner.cc Loading commit data...
task-runner.h Loading commit data...
tasks.cc Loading commit data...
tasks.h Loading commit data...
testcfg.py Loading commit data...
utils.cc Loading commit data...
utils.h Loading commit data...
wasm-inspector-test.js Loading commit data...