• Seth Brenith's avatar
    Reland "Allow lookup of matching scripts in Isolate compilation cache" · 8742d2a2
    Seth Brenith authored
    This is a reland of commit c443858f
    
    The original version included an operation which could left-shift
    signed values, which is undefined behavior; the updated version masks
    the value first to avoid the problem.
    
    Original change's description:
    > Allow lookup of matching scripts in Isolate compilation cache
    >
    > Currently, if the same script text is compiled multiple times with
    > differing details (such as name, line number, or host-defined options),
    > then multiple copies of that script are added to the Isolate's
    > compilation cache. However, any attempt to look up those scripts can
    > find only the first instance. This change makes the script compilation
    > cache behave more consistently by checking the details while searching
    > the hash table for a match, rather than after a potential match has been
    > found.
    >
    > Bug: v8:12808
    > Change-Id: Ic9da0bf74f359d4f1c88af89d585404f173056ee
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3671615
    > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Cr-Commit-Position: refs/heads/main@{#80919}
    
    Bug: v8:12808
    Change-Id: I494c3c9cc520b79f34247aab6618c40c854b9edc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687070Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#81007}
    8742d2a2
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...