-
Clemens Backes authored
The no_condition / kNoCondition not only has the flaw that it's a special case which represents an illegal / nonexisting condition, and thus needs special handling in all methods which get a condition as input (this check is often missing), it is also weird in that every negative condition value must be considered a "no condition". It turns out that this "no condition" is rarely used, and can easily be avoided by duplicating methods, or storing a {base::Optional<Condition>} instead (not needed anywhere yet). This is a follow-up to https://crrev.com/c/3629553. R=tebbi@chromium.org, pthier@chromium.org Bug: v8:12425 Change-Id: Id2270b1660fcb0aff0a8460961b57068ed1c3c73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632102Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#80397}
738f4b69
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
assembler-x64-inl.h | Loading commit data... | |
assembler-x64.cc | ||
assembler-x64.h | ||
constants-x64.h | ||
cpu-x64.cc | ||
fma-instr.h | ||
interface-descriptors-x64-inl.h | ||
macro-assembler-x64.cc | ||
macro-assembler-x64.h | ||
register-x64.h | ||
reglist-x64.h | ||
sse-instr.h |