• Jakob Kummerow's avatar
    Make RegExpFlagsFromString faster · 2cce5c52
    Jakob Kummerow authored
    The new ObjectPtr design makes non-inlined helper functions a little
    more expensive because "this" is always a pointer where pass-by-value
    would be more efficient, which is an issue for functions whose size puts
    them right at the threshold of getting inlined or not. String::Get falls
    into this category when called from RegExpFlagsFromString. In this case,
    we can do even better than restoring inlineability by fine-tuning
    the control flow a bit.
    
    This should repair the regression in crbug.com/910573
    
    Bug: chromium:910573
    Change-Id: Ie6b68ef01cd978ec502d8d6c1da788c77422dce7
    Reviewed-on: https://chromium-review.googlesource.com/c/1369087
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58234}
    2cce5c52
Name
Last commit
Last update
..
Array Loading commit data...
ArrayIndexOfIncludesPolymorphic Loading commit data...
ArrayLiteralInitialSpreadLargeDoubleHoley Loading commit data...
ArrayLiteralInitialSpreadLargeDoublePacked Loading commit data...
ArrayLiteralInitialSpreadLargeHoley Loading commit data...
ArrayLiteralInitialSpreadLargePacked Loading commit data...
ArrayLiteralInitialSpreadLargeSmiMap Loading commit data...
ArrayLiteralInitialSpreadLargeSmiSet Loading commit data...
ArrayLiteralInitialSpreadSmallDoubleHoley Loading commit data...
ArrayLiteralInitialSpreadSmallDoublePacked Loading commit data...
ArrayLiteralInitialSpreadSmallHoley Loading commit data...
ArrayLiteralInitialSpreadSmallPacked Loading commit data...
ArrayLiteralInitialSpreadSmallSmiMap Loading commit data...
ArrayLiteralInitialSpreadSmallSmiSet Loading commit data...
ArrayLiteralSpread Loading commit data...
ArraySort Loading commit data...
AsyncAwait Loading commit data...
BytecodeHandlers Loading commit data...
Classes Loading commit data...
Closures Loading commit data...
Collections Loading commit data...
DataView Loading commit data...
Dates Loading commit data...
Exceptions Loading commit data...
ExpressionDepth Loading commit data...
ForLoops Loading commit data...
Generators Loading commit data...
Inspector Loading commit data...
Iterators Loading commit data...
Keys Loading commit data...
ManyClosures Loading commit data...
Modules Loading commit data...
Numbers Loading commit data...
Object Loading commit data...
ObjectLiteralSpread Loading commit data...
Parsing Loading commit data...
PropertyQueries Loading commit data...
Proxies Loading commit data...
RegExp Loading commit data...
RestParameters Loading commit data...
Scope Loading commit data...
SixSpeed Loading commit data...
SpreadCalls Loading commit data...
SpreadCallsGeneral Loading commit data...
StringIterators Loading commit data...
Strings Loading commit data...
Templates Loading commit data...
TurboFan Loading commit data...
TypedArrays Loading commit data...
JSTests.json Loading commit data...
OWNERS Loading commit data...
RegExp.json Loading commit data...
SixSpeed.json Loading commit data...
base.js Loading commit data...