• Alexey Kozyatinskiy's avatar
    [inspector] provisional breakpoints for anonymous script · 83198829
    Alexey Kozyatinskiy authored
    Use case: anonymous script with sourceMappingUrl. User can set
    breakpoint in source with sourceUrl from sourceMap, we persist this
    breakpoint in DevTools and on page reload breakpoint should be restored
    correctly.
    
    Debugger.setBreakpointByUrl method provides capabilities to set
    provisional breakpoints and looks like best candidate for new "scriptHash"
    argument.
    
    I considered other options such as replacing scriptId with something
    more persistent like "script-hash:script-with-this-hash-number" but it
    looks more complicated and doesn't provide clear advantages.
    
    One pager: http://bit.ly/2wkRHnt
    
    R=pfeldman@chromium.org
    
    Bug: chromium:459499
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I0e2833fceffe6b04afac01d1a4522d6874b6067a
    Reviewed-on: https://chromium-review.googlesource.com/683597
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48357}
    83198829
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...