• Manos Koukoutos's avatar
    [wasm][cleanup] Increase GraphAssembler infra usage in WasmGraphBuilder · 825cb671
    Manos Koukoutos authored
    WasmGraphBuilder often failed to use GraphAssembler infrastructure and
    went with directly invoking graph()->NewNode(). This made the code more
    verbose, especially in cases where effect() and control() had to be
    passes directly to NewNode().
    This CL eliminates these invocations in obvious cases. It does not try
    to refactor complicated code with branches, diamond patterns, etc.
    
    Additional changes:
    - Define a few more operators in GraphAssembler.
    - Move Branch() helper in WasmGraphAssembler.
    - Define NumberConstant() helper in WasmGraphAssembler.
    - Define Merge() helper with varargs in WasmGraphBuilder.
    - Omit IntPtrConstant() wrapper for constant offsets of Load and Store.
    
    Change-Id: I571d5286be8881504cb2060195fbd181d1fce67d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712804Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72975}
    825cb671
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...