• Benedikt Meurer's avatar
    [es9] Fix object cloning wrt. MutableHeapNumbers. · 80f7c4a8
    Benedikt Meurer authored
    Previously the object cloning fast-path had a single loop which would
    initialize the object _and_ at the same time clone MutableHeapNumbers.
    But since that can trigger GCs, the heap verifier was a bit sad to see
    double fields holding undefined values. This was flushed out by the CL
    https://chromium-review.googlesource.com/1655291, which changed the GC
    timing slightly and thus made the test crash in the verifier.
    
    So instead of the one loop, we now have a second loop that takes care
    of cloning any MutableHeapNumbers. This has the advantage that the first
    loop can always run without write barriers.
    
    Bug: chromium:964748, chromium:973045, v8:7611, v8:9114, v8:9183, v8:9343
    Change-Id: I724a1c1e534243ce9ecde95bf0c07ca26363b515
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1655307
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62114}
    80f7c4a8
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...