-
Clemens Backes authored
The tier up check in br_if is only executed conditionally, so it is not allowed to update any cache state. Later code would work with that updated state, even though the corresponding code would not have executed. There was a partial implementation for this by passing in a scratch register for {TierupCheck}, but {TierupCheckOnExit} has the same problem, and needs up to three scratch registers. Until we come up with a better solution, just snapshot the cache state before doing the tier up check, and restore it later. This has some performance cost, but it's an effective fix. R=jkummerow@chromium.org Bug: chromium:1314184 Change-Id: I1272010cc247b755e2f4d40615284a03ff8dadb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3579363Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79896}
8072d31a
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
arm | ||
arm64 | ||
ia32 | ||
loong64 | ||
mips | ||
mips64 | ||
ppc | ||
riscv64 | ||
s390 | ||
x64 | ||
DEPS | ||
liftoff-assembler-defs.h | ||
liftoff-assembler.cc | ||
liftoff-assembler.h | ||
liftoff-compiler.cc | ||
liftoff-compiler.h | ||
liftoff-register.h |