• Aleksey Kozyatinskiy's avatar
    [inspector] moved var initialization break location before init expression (reland) · fb6a094d
    Aleksey Kozyatinskiy authored
    This CL improves break locations for expressions like 'var a = <expr>'. Without CL we use <expr> position as break location for initialization statement, with this CL we use position of first character after '=' as position.
    Benefits (see test for details):
     - only one break in expressions which includes mix of property lookup and calls, e.g. var p = Promise.resolve().then(x => x * 2),
     - removed redundant break location for expressions like: let { x, y } = { x: 1, y: 2}.
     
    TBR=dgozman@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org,marja@chromium.org,kozyatinskiy@chromium.org,devtools-reviews@chromium.org,v8-reviews@googlegroups.com
    # Not skipping CQ checks because original CL landed > 1 day ago.
    Bug: v8:5909
    
    Change-Id: Ie84fa79afeed09e28cf8478ba610a0cfbfdfc294
    Reviewed-on: https://chromium-review.googlesource.com/518116
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45598}
    fb6a094d
Name
Last commit
Last update
..
debug-promises Loading commit data...
regress Loading commit data...
debug-blockscopes.js Loading commit data...
debug-break-default-constructor.js Loading commit data...
debug-evaluate-arrow-function-receiver.js Loading commit data...
debug-evaluate-blockscopes.js Loading commit data...
debug-evaluate-receiver-before-super.js Loading commit data...
debug-exception-generators.js Loading commit data...
debug-function-scopes.js Loading commit data...
debug-liveedit-new-target-1.js Loading commit data...
debug-liveedit-new-target-2.js Loading commit data...
debug-liveedit-new-target-3.js Loading commit data...
debug-scope-default-param-with-eval.js Loading commit data...
debug-step-destructuring-assignment.js Loading commit data...
debug-step-destructuring-bind.js Loading commit data...
debug-step-into-class-extends.js Loading commit data...
debug-step-into-constructor.js Loading commit data...
debug-step-into-regexp-subclass.js Loading commit data...
debug-stepin-collections-foreach.js Loading commit data...
debug-stepin-default-parameters.js Loading commit data...
debug-stepin-generators.js Loading commit data...
debug-stepin-microtasks.js Loading commit data...
debug-stepin-proxies.js Loading commit data...
debug-stepin-string-template.js Loading commit data...
debug-stepin-tailcalls.js Loading commit data...
debug-stepnext-for.js Loading commit data...
debug-stepnext-generators.js Loading commit data...
debug-stepout-tailcalls.js Loading commit data...
default-parameters-debug.js Loading commit data...
generators-debug-liveedit.js Loading commit data...
generators-debug-scopes.js Loading commit data...
generators-relocation.js Loading commit data...