• Milad Farazmand's avatar
    PPC/s390: Reland "Reland: [builtins] Move non-JS linkage builtins code objects into RO_SPACE" · 29112b47
    Milad Farazmand authored
    Port 352bbb12
    
    Original Commit Message:
    
        This is a reland of 855591a5
    
        Fixes break in builds that verify ReadOnlyHeap by relaxing the requirement for
        Code objects to be in CODE_SPACE in PagedSpaceObjectIterator::FromCurrentPage.
    
        Original change's description:
        > Reland: [builtins] Move non-JS linkage builtins code objects into RO_SPACE
        >
        > Reland of https://chromium-review.googlesource.com/c/v8/v8/+/1795358.
        >
        > [builtins] Move non-JS linkage builtins code objects into RO_SPACE
        >
        > Creates an allow-list of builtins that can still go in code_space
        > including all TFJ builtins and a small manual list that should be pared
        > down in the future.
        >
        > For builtins that go in RO_SPACE a Code object is created that contains an
        > immediate trap instruction. Generally these Code objects are still no
        > smaller than CODE_SPACE Code objects because of the Code object alignment
        > requirements. This will hopefully be addressed in a follow-up CL either by
        > relaxing them or removing the instruction stream completely.
        >
        > In the snapshot, this reduces code_space from ~152k to ~40k (-112k) and
        > increases by the same amount.
        >
        > Change-Id: I76661c35c7ea5866c1fb16e87e87122b3e3ca0ce
        > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1893336
        > Commit-Queue: Dan Elphick <delphick@chromium.org>
        > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
        > Cr-Commit-Position: refs/heads/master@{#64700}
    
    R=delphick@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
    BUG=
    LOG=N
    
    Change-Id: If150434119828a87e295b0639c934392812bb345
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1896904Reviewed-by: 's avatarMilad Farazmand <miladfar@ca.ibm.com>
    Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
    Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#64741}
    29112b47
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...