• Shu-yu Guo's avatar
    Revert "[base] Add new API to protect data memory" · b0929a93
    Shu-yu Guo authored
    This reverts commit 9d36b2dd.
    
    Reason for revert: Win64 crashes
    https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64%20-%20debug/43496/overview
    
    Original change's description:
    > [base] Add new API to protect data memory
    >
    > This adds a new {base::OS::SetDataReadOnly} method, which is similar to
    > {SetPermissions(kRead)}, but using another system call on Windows such
    > that it works on pages in the data segment.
    > {VirtualAlloc} will fail if called on a page of the data section,
    > whereas {VirtualProtect} succeeds. For the general {SetPermissions}
    > API we still want to use {VirtualAlloc} though, as it also changes the "committed" state of the pages.
    >
    > Note that we do not add a platform API for this, as the memory was
    > never allocated through the platform. We just directly protect it in
    > V8.
    >
    > R=​mlippautz@chromium.org
    >
    > Bug: v8:12887
    > Change-Id: If83bf6e5c500cc5cf08c76d04dfac5e2b4d35a2d
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820482
    > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#82349}
    
    Bug: v8:12887
    Change-Id: I86fffa60d6766dcdaf44f57f18266fec22eb9016
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3824409
    Auto-Submit: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Owners-Override: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82360}
    b0929a93
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
flags Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
js-atomics Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regexp Loading commit data...
regress Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
tracing Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
avoid-windows-h-includes.cc Loading commit data...
gay-fixed.cc Loading commit data...
gay-fixed.h Loading commit data...
gay-precision.cc Loading commit data...
gay-precision.h Loading commit data...
gay-shortest.cc Loading commit data...
gay-shortest.h Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...