• Ben L. Titzer's avatar
    Reland "Reland "[arraybuffer] Rearchitect backing store ownership"" · 306cf403
    Ben L. Titzer authored
    This is a reland of bc33f5ae
    
    Original change's description:
    > Reland "[arraybuffer] Rearchitect backing store ownership"
    > 
    > This is a reland of 31cd5d83
    > 
    > Original change's description:
    > > [arraybuffer] Rearchitect backing store ownership
    > > 
    > > This CL completely rearchitects the ownership of array buffer backing stores,
    > > consolidating ownership into a {BackingStore} C++ object that is tracked
    > > throughout V8 using unique_ptr and shared_ptr where appropriate.
    > > 
    > > Overall, lifetime management is simpler and more explicit. The numerous
    > > ways that array buffers were initialized have been streamlined to one
    > > Attach() method on JSArrayBuffer. The array buffer tracker in the
    > > GC implementation now manages std::shared_ptr<BackingStore> pointers,
    > > and the construction and destruction of the BackingStore object itself
    > > handles the underlying page or embedder-allocated memory.
    > > 
    > > The embedder API remains unchanged for now. We use the
    > > v8::ArrayBuffer::Contents struct to hide an additional shared_ptr to
    > > keep the backing store alive properly, even in the case of aliases
    > > from live heap objects. Thus the embedder has a lower chance of making
    > > a mistake. Long-term, we should move the embedder to a model where they
    > > manage backing stores using shared_ptr to an opaque backing store object.
    > > 
    > > R=mlippautz@chromium.org
    > > BUG=v8:9380,v8:9221
    > > 
    > > Change-Id: I48fae5ac85dcf6172a83f252439e77e7c1a16ccd
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1584323
    > > Commit-Queue: Ben Titzer <titzer@chromium.org>
    > > Reviewed-by: Ben Titzer <titzer@chromium.org>
    > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
    > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#62572}
    > 
    > Bug: v8:9380, v8:9221
    > Change-Id: If3f72967a8ebeb067c0edcfc16ed631e36829dbc
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691906
    > Commit-Queue: Ben Titzer <titzer@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#62809}
    
    Bug: v8:9380, v8:9221
    Change-Id: I9a2525753ae2424108d074fa81df5f25d945c824
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1709409
    Commit-Queue: Ben Titzer <titzer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62847}
    306cf403
Name
Last commit
Last update
..
OWNERS Loading commit data...
array-buffer-collector.cc Loading commit data...
array-buffer-collector.h Loading commit data...
array-buffer-tracker-inl.h Loading commit data...
array-buffer-tracker.cc Loading commit data...
array-buffer-tracker.h Loading commit data...
barrier.h Loading commit data...
basic-memory-chunk.cc Loading commit data...
basic-memory-chunk.h Loading commit data...
code-stats.cc Loading commit data...
code-stats.h Loading commit data...
combined-heap.cc Loading commit data...
combined-heap.h Loading commit data...
concurrent-marking.cc Loading commit data...
concurrent-marking.h Loading commit data...
embedder-tracing.cc Loading commit data...
embedder-tracing.h Loading commit data...
factory-inl.h Loading commit data...
factory.cc Loading commit data...
factory.h Loading commit data...
gc-idle-time-handler.cc Loading commit data...
gc-idle-time-handler.h Loading commit data...
gc-tracer.cc Loading commit data...
gc-tracer.h Loading commit data...
heap-controller.cc Loading commit data...
heap-controller.h Loading commit data...
heap-inl.h Loading commit data...
heap-write-barrier-inl.h Loading commit data...
heap-write-barrier.h Loading commit data...
heap.cc Loading commit data...
heap.h Loading commit data...
incremental-marking-inl.h Loading commit data...
incremental-marking-job.cc Loading commit data...
incremental-marking-job.h Loading commit data...
incremental-marking.cc Loading commit data...
incremental-marking.h Loading commit data...
invalidated-slots-inl.h Loading commit data...
invalidated-slots.cc Loading commit data...
invalidated-slots.h Loading commit data...
item-parallel-job.cc Loading commit data...
item-parallel-job.h Loading commit data...
local-allocator-inl.h Loading commit data...
local-allocator.h Loading commit data...
mark-compact-inl.h Loading commit data...
mark-compact.cc Loading commit data...
mark-compact.h Loading commit data...
marking.cc Loading commit data...
marking.h Loading commit data...
memory-reducer.cc Loading commit data...
memory-reducer.h Loading commit data...
object-stats.cc Loading commit data...
object-stats.h Loading commit data...
objects-visiting-inl.h Loading commit data...
objects-visiting.cc Loading commit data...
objects-visiting.h Loading commit data...
read-only-heap-inl.h Loading commit data...
read-only-heap.cc Loading commit data...
read-only-heap.h Loading commit data...
remembered-set.h Loading commit data...
scavenge-job.cc Loading commit data...
scavenge-job.h Loading commit data...
scavenger-inl.h Loading commit data...
scavenger.cc Loading commit data...
scavenger.h Loading commit data...
setup-heap-internal.cc Loading commit data...
slot-set.cc Loading commit data...
slot-set.h Loading commit data...
spaces-inl.h Loading commit data...
spaces.cc Loading commit data...
spaces.h Loading commit data...
store-buffer-inl.h Loading commit data...
store-buffer.cc Loading commit data...
store-buffer.h Loading commit data...
stress-marking-observer.cc Loading commit data...
stress-marking-observer.h Loading commit data...
stress-scavenge-observer.cc Loading commit data...
stress-scavenge-observer.h Loading commit data...
sweeper.cc Loading commit data...
sweeper.h Loading commit data...
worklist.h Loading commit data...