• Mike Stanton's avatar
    [compiler] Representation mismatch detection missed a case · 758816f4
    Mike Stanton authored
    In GetOwnFastDataPropertyFromHeap, we read a property value
    then compare it with the expected representation. We already
    had code to bail out of that particular optimization if there
    was a mismatch, however it missed the case of expected
    representation being a HeapObject, and when a Smi value was found.
    
    The fix is to use the excellent pre-existing method
    Object::FitsRepresentation() to make this check. Thusly, all
    cases are handled.
    
    Bug: chromium:1225607, v8:7790
    Change-Id: I7d9b1b7722d9691cf5427f8456a6deb466dda0d3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008218
    Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    Reviewed-by: 's avatarSantiago Aboy Solanes <solanes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75587}
    758816f4
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...