• Clemens Backes's avatar
    [wasm][arm64] Fix zero-extention of i32.load8_s · 748ae7cb
    Clemens Backes authored
    InstructionSelector::ZeroExtendsWord32ToWord64 assumes that a
    Load[kRepWord8|kTypeInt32] generates a zero-extended value. This
    assumption makes sense, but was not fulfilled by the instruction
    selector which emitted an "ldrsb" instruction which sign-extended to the
    full 64-bit register.
    
    This CL fixes that by introducing a separate "LdrsbW" instruction which
    is selected if we are sign-extending an 8-bit value to 32-bit.
    
    R=ahaas@chromium.org, mslekova@chromium.org
    CC=v8-arm-ports@googlegroups.com
    
    Bug: chromium:1239116
    Change-Id: I2da1ad6062805acf5558f3e66b8db9a50e830302
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094011
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76283}
    748ae7cb
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...