• adamk's avatar
    Don't crash when preparsing destructured arguments · 7485da7a
    adamk authored
    This adds the materialized literal count accumulated while parsing the
    parameters (in the parser proper) to that accumulated by the preparser.
    
    This should have been caught in cctest/test-parsing, but it's not covered
    because the parsing tests call directly into the preparser rather than
    using Parser::ParseFunctionLiteral (which fully-parses the parameters
    and then calls into the preparser to skip over the function body).
    
    Note that this further-inflates the materialized literal count for
    functions with destructured arguments, since some of the counted
    literals are actually binding patterns. But that's not specific to
    binding patterns in formal parameters: it happens in function bodies, too.
    
    BUG=v8:4400,v8:4407
    LOG=n
    
    Review URL: https://codereview.chromium.org/1350913005
    
    Cr-Commit-Position: refs/heads/master@{#30868}
    7485da7a
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...