• Simon Zünd's avatar
    Reset DeclarationScope::function_ variable after pre-parsing · 70dd77c7
    Simon Zünd authored
    "--print-scopes" uses the {function_} variable to print the function
    name and locals of a function scope. In case of a pre-parsed function,
    the function variable of the scope lives in a zone which is nuked after
    pre-parsing, while the scope lives on. This leaves the {function_}
    variable pointer in the scope in a state where it points to
    invalid memory, causing "--print-scopes" to crash.
    This CL fixes the crash by properly resetting the {function_}
    pointer.
    
    TBR=verwaest@chromium.org
    
    Change-Id: Id24dbb605bec883317f676265a920fe0ca662301
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1776094Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Auto-Submit: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63513}
    70dd77c7
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...