• Benedikt Meurer's avatar
    Reland "[typedarray] Move external/data pointer to JSTypedArray." · 70bd7cf0
    Benedikt Meurer authored
    This is a reland of 4b86fea5 with
    copy&paste typo in CodeStubAssembler::AllocateByteArray() fixed
    (bug led to holes in new space, which was crashing reproducibly
    on the ia32 bot).
    
    Original change's description:
    > [typedarray] Move external/data pointer to JSTypedArray.
    >
    > As the next step in supporting huge typed arrays in V8, this moves the
    > external/data pointer from the FixedTypedArrayBase backing store to the
    > JSTypedArray instance itself, and replaces the special backing stores
    > with a plain ByteArray (removing all the code for the FixedTypedArrayBase
    > class hierarchy). By doing so, we can drastically simplify the system
    > around typed arrays.
    >
    > Note: Several places in the code base used to check the instance type
    > of the elements backing store of a JSTypedArray instead of checking the
    > elements kind on the JSTypedArray map directly. Those had to be fixed,
    > since the backing store is now always a ByteArray.
    >
    > Drive-by-fix: Move all the typed elements access related code into the
    > elements.cc file to properly encapsulate the accesses.
    >
    > Doc: http://doc/1Z-wM2qwvAuxH46e9ivtkYvKzzwYZg8ymm0x0wJaomow
    > Bug: chromium:951196, chromium:965583, v8:4153, v8:7881, v8:9183
    > Change-Id: I8cc06b190c53e34155000b4560f5f3ef40621646
    > Cq-Include-Trybots: luci.chromium.try:linux-rel,win7-rel
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627535
    > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Reviewed-by: Simon Zünd <szuend@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#61855}
    
    Tbr: petermarshall@chromium.org
    Bug: chromium:951196, chromium:965583, v8:4153, v8:7881, v8:9183
    Change-Id: I87fcdb28532c5f08cc227332a4d59546cb423810
    Cq-Include-Trybots: luci.chromium.try:linux-rel, win7-rel
    Cq-Include-Trybots: luci.v8.try:v8_linux_shared_compile_rel
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631592Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61864}
    70bd7cf0
Name
Last commit
Last update
..
api Loading commit data...
arm Loading commit data...
arm64 Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ia32 Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
ppc Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
s390 Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
x64 Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...