• Benedikt Meurer's avatar
    [debug] Set breakpoints correctly right after function literals. · 6d25f20f
    Benedikt Meurer authored
    The logic to locate the correct function to set a breakpoint in based
    on script position was treating SharedFunctionInfo::EndPosition() as
    inclusive rather than exclusive. There are various assumptions all over
    the Debugger that seem to demand this treatment for the toplevel script.
    But it's definitely wrong for function literals.
    
    Fixed: chromium:1253277
    Change-Id: I3421703673f4d78aee28e923e03e2fca24bc06ac
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3197715
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77186}
    6d25f20f
Name
Last commit
Last update
..
benchmarks Loading commit data...
bigint Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...