• Seth Brenith's avatar
    Revert "Remove 'length' field from ScopeInfo" · 6c922e39
    Seth Brenith authored
    This reverts commit f731e13f.
    
    Reason for revert: perf regressions, chromium:1179757
    
    Original change's description:
    > Remove 'length' field from ScopeInfo
    >
    > ScopeInfo has a vestigial 'length' field from when it used to be a
    > FixedArray. This change removes that field, which saves some memory.
    >
    > More specifically:
    >
    > - Make ScopeInfo inherit from HeapObject, not FixedArrayBase which
    >   supplied the 'length' field.
    > - Privatize the FixedArray-style functions that provide access to
    >   ScopeInfo fields by index, and move them from scope-info-inl.h to
    >   scope-info.cc. Those functions are still used pretty heavily during
    >   initialization (ScopeInfo::Create, etc.), but at least we can avoid
    >   presenting them to the rest of the world.
    > - Change FactoryBase::NewScopeInfo to allocate the updated object shape.
    >   It maintains the existing behavior of filling the newly-allocated
    >   object with undefined, even though that's not a valid ScopeInfo and
    >   further initialization is required.
    > - Move part of AccessorAssembler::ScriptContextTableLookup into a new
    >   Torque macro, because it used to rely on casting ScopeInfo to
    >   FixedArrayBase.
    > - In V8HeapExplorer::AddEntry, don't claim that ScopeInfo objects are
    >   arrays. I think it makes more sense to list them under "(system)" in
    >   the dev tools, like most other V8 internal types.
    >
    > Bug: v8:8952
    > Change-Id: I8278e3a90027d4409f0d268da0fe7080754c6b8c
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2601880
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    > Reviewed-by: Mythri Alle <mythria@chromium.org>
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#72830}
    
    Bug: v8:8952
    Change-Id: I00a69da79e5ac6aaae4436a41ce773ae014cc775
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2706086
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Auto-Submit: Seth Brenith <seth.brenith@microsoft.com>
    Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72855}
    6c922e39
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
riscv64 Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
aligned-slot-allocator.cc Loading commit data...
aligned-slot-allocator.h Loading commit data...
assembler-arch.h Loading commit data...
assembler-inl.h Loading commit data...
assembler.cc Loading commit data...
assembler.h Loading commit data...
bailout-reason.cc Loading commit data...
bailout-reason.h Loading commit data...
callable.h Loading commit data...
code-comments.cc Loading commit data...
code-comments.h Loading commit data...
code-desc.cc Loading commit data...
code-desc.h Loading commit data...
code-factory.cc Loading commit data...
code-factory.h Loading commit data...
code-reference.cc Loading commit data...
code-reference.h Loading commit data...
code-stub-assembler.cc Loading commit data...
code-stub-assembler.h Loading commit data...
compilation-cache.cc Loading commit data...
compilation-cache.h Loading commit data...
compiler.cc Loading commit data...
compiler.h Loading commit data...
constant-pool.cc Loading commit data...
constant-pool.h Loading commit data...
constants-arch.h Loading commit data...
cpu-features.h Loading commit data...
external-reference-encoder.cc Loading commit data...
external-reference-encoder.h Loading commit data...
external-reference-table.cc Loading commit data...
external-reference-table.h Loading commit data...
external-reference.cc Loading commit data...
external-reference.h Loading commit data...
flush-instruction-cache.cc Loading commit data...
flush-instruction-cache.h Loading commit data...
handler-table.cc Loading commit data...
handler-table.h Loading commit data...
interface-descriptors.cc Loading commit data...
interface-descriptors.h Loading commit data...
label.h Loading commit data...
machine-type.cc Loading commit data...
machine-type.h Loading commit data...
macro-assembler-inl.h Loading commit data...
macro-assembler.h Loading commit data...
optimized-compilation-info.cc Loading commit data...
optimized-compilation-info.h Loading commit data...
pending-optimization-table.cc Loading commit data...
pending-optimization-table.h Loading commit data...
register-arch.h Loading commit data...
register-configuration.cc Loading commit data...
register-configuration.h Loading commit data...
register.h Loading commit data...
reglist.h Loading commit data...
reloc-info.cc Loading commit data...
reloc-info.h Loading commit data...
safepoint-table.cc Loading commit data...
safepoint-table.h Loading commit data...
signature.h Loading commit data...
source-position-table.cc Loading commit data...
source-position-table.h Loading commit data...
source-position.cc Loading commit data...
source-position.h Loading commit data...
string-constants.cc Loading commit data...
string-constants.h Loading commit data...
tick-counter.cc Loading commit data...
tick-counter.h Loading commit data...
tnode.cc Loading commit data...
tnode.h Loading commit data...
turbo-assembler.cc Loading commit data...
turbo-assembler.h Loading commit data...
unoptimized-compilation-info.cc Loading commit data...
unoptimized-compilation-info.h Loading commit data...