• Andreas Haas's avatar
    [wasm][ia32] Fix i64tof32 conversion on Windows · 4df3db7b
    Andreas Haas authored
    On Windows, the FP stack registers are used with less precision.
    This causes rounding errors in the uint64 to float32 conversion.
    
    This CL replaces the implementation based on FP stack registers
    with an implementation based on bit operations. This implementation
    is 2x slower than the original implementation.
    
    An alternative would be to change the precision of the FP stack
    registers just for the uint64 to float32 conversion. However, in a
    micro-benchmark this is 5-6x slower than the original implementation.
    It is also not clear if changing the precision could cause side
    effects.
    
    R=clemensh@chromium.org
    
    Change-Id: Iaab6b6f258ff01e0c6e93f3632daf516fae3e74b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708486
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62986}
    4df3db7b
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...