• Clemens Backes's avatar
    Revert "[wasm] Refactor callback triggering" · 6a2865d2
    Clemens Backes authored
    This reverts commit 0dc598df.
    
    Reason for revert: Fails the wasm-cache-test blink test.
    
    Original change's description:
    > [wasm] Refactor callback triggering
    > 
    > 1) Instead of passing three boolean values to |TriggerCallbacks|, pass
    >    one EnumSet which contains all events to trigger.
    > 2) Remember which events already happened, to avoid triggering them
    >    again.
    > 3) Compute triggered events once after the loop in |OnFinishedUnits|,
    >    instead of checking for every finished unit.
    > 4) When a new callback is registered, trigger all previous events
    >    immediately. This solves issue v8:10217.
    > 5) Replace |NotifyTopTierReady| by |AddCallback| which is identical now.
    > 6) Do not call |OnFinishedJSToWasmWrapperUnits| if no wrappers were
    >    compiled (this is a minor performance optimization; we save taking
    >    and releasing a lock).
    > 7) Drive-by: Make the |EnumSet| constructor really constexpr (by making
    >    |Mask| constexpr).
    > 
    > R=​ahaas@chromium.org
    > 
    > Bug: v8:10217
    > Change-Id: Ib3688a1687ad7b523e90efd73f4073e9f1193016
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072737
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#66459}
    
    TBR=ahaas@chromium.org,clemensb@chromium.org
    
    Change-Id: I564b053e898db5f7b51cefa4626c0625a225c89a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10217
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074638Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66461}
    6a2865d2
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...