• Jakob Gruber's avatar
    [regexp] Limit the size of inlined choice nodes · 6a0e7224
    Jakob Gruber authored
    Codegen for unicode property escapes (e.g.: /\p{L}/u) can produce huge
    code objects. This effect can be further magnified through inlining,
    leading to exponential code growth in the size of the pattern.
    
    This CL is a (fairly hacky) way to avoid exponential growth. We
    recognize choice nodes with 'many' choices and disable inlining for
    them. In the future we should fix this properly, either by using the
    code size budget correctly, or by improving codegen for property
    escapes.
    
    Bug: v8:10441
    Change-Id: I817f145251ec8b1b9906cc735c9e9bdb004c98ed
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2170229
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67433}
    6a0e7224
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...