• Shu-yu Guo's avatar
    Revert "[base] Add new API to protect data memory" · b0929a93
    Shu-yu Guo authored
    This reverts commit 9d36b2dd.
    
    Reason for revert: Win64 crashes
    https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64%20-%20debug/43496/overview
    
    Original change's description:
    > [base] Add new API to protect data memory
    >
    > This adds a new {base::OS::SetDataReadOnly} method, which is similar to
    > {SetPermissions(kRead)}, but using another system call on Windows such
    > that it works on pages in the data segment.
    > {VirtualAlloc} will fail if called on a page of the data section,
    > whereas {VirtualProtect} succeeds. For the general {SetPermissions}
    > API we still want to use {VirtualAlloc} though, as it also changes the "committed" state of the pages.
    >
    > Note that we do not add a platform API for this, as the memory was
    > never allocated through the platform. We just directly protect it in
    > V8.
    >
    > R=​mlippautz@chromium.org
    >
    > Bug: v8:12887
    > Change-Id: If83bf6e5c500cc5cf08c76d04dfac5e2b4d35a2d
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820482
    > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#82349}
    
    Bug: v8:12887
    Change-Id: I86fffa60d6766dcdaf44f57f18266fec22eb9016
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3824409
    Auto-Submit: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Owners-Override: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82360}
    b0929a93
Name
Last commit
Last update
..
platform Loading commit data...
utils Loading commit data...
address-region-unittest.cc Loading commit data...
atomic-utils-unittest.cc Loading commit data...
atomicops-unittest.cc Loading commit data...
bignum-dtoa-unittest.cc Loading commit data...
bignum-unittest.cc Loading commit data...
bits-unittest.cc Loading commit data...
cpu-unittest.cc Loading commit data...
division-by-constant-unittest.cc Loading commit data...
double-unittest.cc Loading commit data...
dtoa-unittest.cc Loading commit data...
fast-dtoa-unittest.cc Loading commit data...
fixed-dtoa-unittest.cc Loading commit data...
flags-unittest.cc Loading commit data...
functional-unittest.cc Loading commit data...
hashmap-unittest.cc Loading commit data...
ieee754-unittest.cc Loading commit data...
iterator-unittest.cc Loading commit data...
logging-unittest.cc Loading commit data...
macros-unittest.cc Loading commit data...
ostreams-unittest.cc Loading commit data...
region-allocator-unittest.cc Loading commit data...
string-format-unittest.cc Loading commit data...
sys-info-unittest.cc Loading commit data...
template-utils-unittest.cc Loading commit data...
threaded-list-unittest.cc Loading commit data...
vector-unittest.cc Loading commit data...
virtual-address-space-unittest.cc Loading commit data...
vlq-base64-unittest.cc Loading commit data...
vlq-unittest.cc Loading commit data...