• Leszek Swirski's avatar
    Revert "[parser] Slice the source string where possible" · 18bc2856
    Leszek Swirski authored
    This reverts commit 2df5e7a7.
    
    Reason for revert: Mystery crashes https://bugs.chromium.org/p/chromium/issues/detail?id=838805
    
    Original change's description:
    > [parser] Slice the source string where possible
    > 
    > When internalizing string literals (for quoted strings or property names),
    > try to create a sliced string of the source string rather than allocating
    > a copy of the bytes.
    > 
    > This will not work for string literals that contain escapes (e.g. unicode
    > escapes), and currently does not support two-byte strings.
    > 
    > Bug: chromium:818642
    > Change-Id: I686e5ad36baecd1a84ce5e124118431249b6c980
    > Reviewed-on: https://chromium-review.googlesource.com/1010282
    > Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
    > Reviewed-by: Marja Hölttä <marja@chromium.org>
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#52898}
    
    TBR=marja@chromium.org,yangguo@chromium.org,jarin@chromium.org,mlippautz@chromium.org,leszeks@chromium.org,verwaest@chromium.org
    
    Change-Id: I598b6668c43a3e843e2dd8e60852b2b2f3461954
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:818642
    Reviewed-on: https://chromium-review.googlesource.com/1039885
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52919}
    18bc2856
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
base Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
parser Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
allocation-unittest.cc Loading commit data...
bigint-unittest.cc Loading commit data...
cancelable-tasks-unittest.cc Loading commit data...
char-predicates-unittest.cc Loading commit data...
code-stub-assembler-unittest.cc Loading commit data...
code-stub-assembler-unittest.h Loading commit data...
counters-unittest.cc Loading commit data...
detachable-vector-unittest.cc Loading commit data...
eh-frame-iterator-unittest.cc Loading commit data...
eh-frame-writer-unittest.cc Loading commit data...
locked-queue-unittest.cc Loading commit data...
object-unittest.cc Loading commit data...
register-configuration-unittest.cc Loading commit data...
run-all-unittests.cc Loading commit data...
source-position-table-unittest.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unicode-unittest.cc Loading commit data...
unittests.status Loading commit data...
utils-unittest.cc Loading commit data...
value-serializer-unittest.cc Loading commit data...