• Shu-yu Guo's avatar
    Revert "[regexp] Reorganize and deduplicate in the regexp parser" · 294a77ea
    Shu-yu Guo authored
    This reverts commit 7d849870.
    
    Reason for revert: Will block roll. Broke error message tests upstream:
    
    https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Blink%20Win/6635/overview
    
    
    Original change's description:
    > [regexp] Reorganize and deduplicate in the regexp parser
    >
    > The parser is organized in a somewhat tricky way s.t. it can be
    > hard to map the implementation back to the specified grammar.
    >
    > In particular, the logic for CharacterClassEscape, ClassEscape,
    > and CharacterEscape was implemented twice - once inside a character
    > class, once outside.
    >
    > This CL refactors related logic to have only a single implementation.
    >
    > As a drive-by, fix one related inconsistency related to \k inside
    > a character class.
    >
    > Fixed: v8:10602
    > Change-Id: I5858840159694fa6f8d1aa857027db80754e3dfd
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3178966
    > Reviewed-by: Mathias Bynens <mathias@chromium.org>
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#77114}
    
    Change-Id: Ic7404d6c9f0e6ea51e8cd8f1ab672856dca0c637
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190692
    Auto-Submit: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#77125}
    294a77ea
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
experimental Loading commit data...
ia32 Loading commit data...
loong64 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
riscv64 Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
gen-regexp-special-case.cc Loading commit data...
property-sequences.cc Loading commit data...
property-sequences.h Loading commit data...
regexp-ast.cc Loading commit data...
regexp-ast.h Loading commit data...
regexp-bytecode-generator-inl.h Loading commit data...
regexp-bytecode-generator.cc Loading commit data...
regexp-bytecode-generator.h Loading commit data...
regexp-bytecode-peephole.cc Loading commit data...
regexp-bytecode-peephole.h Loading commit data...
regexp-bytecodes.cc Loading commit data...
regexp-bytecodes.h Loading commit data...
regexp-compiler-tonode.cc Loading commit data...
regexp-compiler.cc Loading commit data...
regexp-compiler.h Loading commit data...
regexp-dotprinter.cc Loading commit data...
regexp-dotprinter.h Loading commit data...
regexp-error.cc Loading commit data...
regexp-error.h Loading commit data...
regexp-flags.h Loading commit data...
regexp-interpreter.cc Loading commit data...
regexp-interpreter.h Loading commit data...
regexp-macro-assembler-arch.h Loading commit data...
regexp-macro-assembler-tracer.cc Loading commit data...
regexp-macro-assembler-tracer.h Loading commit data...
regexp-macro-assembler.cc Loading commit data...
regexp-macro-assembler.h Loading commit data...
regexp-nodes.h Loading commit data...
regexp-parser.cc Loading commit data...
regexp-parser.h Loading commit data...
regexp-stack.cc Loading commit data...
regexp-stack.h Loading commit data...
regexp-utils.cc Loading commit data...
regexp-utils.h Loading commit data...
regexp.cc Loading commit data...
regexp.h Loading commit data...
special-case.h Loading commit data...