• Clemens Hammacher's avatar
    [wasm] [interpreter] Fix fall-through loop with value · 66f69540
    Clemens Hammacher authored
    Executing the |end| opcode of a loop assumed that the stack height was
    being reset to the height at start of the loop. Hence we were ignoring
    the arity of the loop.
    During computation of the side table, the arity of the label associated
    with the loop was explicitly set to 0, such that a |br| instruction to
    that label would not transfer any values.
    It turns out though that we need to remember the arity in order to
    precompute the correct stack height when executing the |end| opcode of
    a loop.
    Also, add a regression test.
    
    R=rossberg@chromium.org
    BUG=chromium:716936
    
    Change-Id: Ib3a559998f1ce5f8fcd7b94af1426637b3e48f86
    Reviewed-on: https://chromium-review.googlesource.com/493286
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarAndreas Rossberg <rossberg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45041}
    66f69540
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...