• Michael Lippautz's avatar
    Revert "cppgc: Rework prefinalizers" · f46c4858
    Michael Lippautz authored
    This reverts commit cf25b3bc.
    
    Reason for revert: https://crbug.com/1307471. TraceTrait must only be used during marking.
    
    Original change's description:
    > cppgc: Rework prefinalizers
    >
    > Move the check for whether an object is live or dead out of the
    > prefinalizer trampoline. Moving it into the backend allows for
    > inlining the check which avoids a call to the trampoline for live
    > objects.
    >
    > On catapult benchmarks (e.g. cnn:2021, nytimes:2020), there's often
    > ~2k finalizers registered. In order to avoid memory overhead in the
    > range of a few KB, we store the fact whether the object points to the
    > base object payload in the LSB of the pointer. For caged builds this
    > is replaced with just storing the index into the cage for both object
    > and base object payload.
    >
    > Locally saves around ~10% of atomic sweeping processing time which is
    > in the order of .05ms.
    >
    > Bug: v8:12698
    > Change-Id: I198205a6b1d57fc2df821ee4e73e53dc6f825ff5
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497764
    > Reviewed-by: Omer Katz <omerkatz@chromium.org>
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#79442}
    
    Bug: v8:12698, chromium:1307471
    Change-Id: I5c4e70d46cb99af66c77f0c013625b6af6c6eb8e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3535781
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79527}
    f46c4858
Name
Last commit
Last update
..
DEPS Loading commit data...
allocation.cc Loading commit data...
caged-heap-local-data.cc Loading commit data...
caged-heap.cc Loading commit data...
caged-heap.h Loading commit data...
compaction-worklists.cc Loading commit data...
compaction-worklists.h Loading commit data...
compactor.cc Loading commit data...
compactor.h Loading commit data...
concurrent-marker.cc Loading commit data...
concurrent-marker.h Loading commit data...
default-platform.cc Loading commit data...
explicit-management.cc Loading commit data...
free-list.cc Loading commit data...
free-list.h Loading commit data...
garbage-collector.h Loading commit data...
gc-info-table.cc Loading commit data...
gc-info-table.h Loading commit data...
gc-info.cc Loading commit data...
gc-invoker.cc Loading commit data...
gc-invoker.h Loading commit data...
globals.h Loading commit data...
heap-base.cc Loading commit data...
heap-base.h Loading commit data...
heap-consistency.cc Loading commit data...
heap-growing.cc Loading commit data...
heap-growing.h Loading commit data...
heap-object-header.cc Loading commit data...
heap-object-header.h Loading commit data...
heap-page.cc Loading commit data...
heap-page.h Loading commit data...
heap-space.cc Loading commit data...
heap-space.h Loading commit data...
heap-state.cc Loading commit data...
heap-statistics-collector.cc Loading commit data...
heap-statistics-collector.h Loading commit data...
heap-visitor.h Loading commit data...
heap.cc Loading commit data...
heap.h Loading commit data...
incremental-marking-schedule.cc Loading commit data...
incremental-marking-schedule.h Loading commit data...
liveness-broker.cc Loading commit data...
liveness-broker.h Loading commit data...
logging.cc Loading commit data...
marker.cc Loading commit data...
marker.h Loading commit data...
marking-state.cc Loading commit data...
marking-state.h Loading commit data...
marking-verifier.cc Loading commit data...
marking-verifier.h Loading commit data...
marking-visitor.cc Loading commit data...
marking-visitor.h Loading commit data...
marking-worklists.cc Loading commit data...
marking-worklists.h Loading commit data...
memory.cc Loading commit data...
memory.h Loading commit data...
metric-recorder.h Loading commit data...
name-trait.cc Loading commit data...
object-allocator.cc Loading commit data...
object-allocator.h Loading commit data...
object-poisoner.h Loading commit data...
object-size-trait.cc Loading commit data...
object-start-bitmap.h Loading commit data...
object-view.h Loading commit data...
page-memory.cc Loading commit data...
page-memory.h Loading commit data...
persistent-node.cc Loading commit data...
platform.cc Loading commit data...
platform.h Loading commit data...
pointer-policies.cc Loading commit data...
prefinalizer-handler.cc Loading commit data...
prefinalizer-handler.h Loading commit data...
process-heap-statistics.cc Loading commit data...
process-heap-statistics.h Loading commit data...
process-heap.cc Loading commit data...
process-heap.h Loading commit data...
raw-heap.cc Loading commit data...
raw-heap.h Loading commit data...
remembered-set.cc Loading commit data...
remembered-set.h Loading commit data...
source-location.cc Loading commit data...
stats-collector.cc Loading commit data...
stats-collector.h Loading commit data...
sweeper.cc Loading commit data...
sweeper.h Loading commit data...
task-handle.h Loading commit data...
testing.cc Loading commit data...
trace-event.h Loading commit data...
trace-trait.cc Loading commit data...
unmarker.h Loading commit data...
virtual-memory.cc Loading commit data...
virtual-memory.h Loading commit data...
visitor.cc Loading commit data...
visitor.h Loading commit data...
write-barrier.cc Loading commit data...
write-barrier.h Loading commit data...