• bmeurer's avatar
    Revert of [es6] Introduce spec compliant IsConstructor. (patchset #2 id:20001... · 656ebdce
    bmeurer authored
    Revert of [es6] Introduce spec compliant IsConstructor. (patchset #2 id:20001 of https://codereview.chromium.org/1358423002/ )
    
    Reason for revert:
    Failed on Fuzzer and MIPS bot.
    
    Original issue's description:
    > [es6] Introduce spec compliant IsConstructor.
    >
    > There was already a bit on the Map named "function with prototype",
    > which basically meant that the Map was a map for a JSFunction that could
    > be used as a constructor. Now this CL generalizes that bit to
    > IsConstructor, which says that whatever (Heap)Object you are looking at
    > can be used as a constructor (i.e. the bit is also set for bound
    > functions that can be used as constructors and proxies that have a
    > [[Construct]] internal method).
    >
    > This way we have a single chokepoint for IsConstructor checking, which
    > allows us to get rid of the various ways in which we tried to guess
    > whether something could be used as a constructor or not.
    >
    > Drive-by-fix: Renamed IsConstructor on FunctionKind to
    > IsClassConstructor to resolve the weird name clash, and the
    > IsClassConstructor name also matches the spec.
    >
    > R=jarin@chromium.org, rossberg@chromium.org
    > BUG=v8:4430
    > LOG=n
    >
    > Committed: https://crrev.com/8de4d9351df4cf66c8a128d561a6e331d196be54
    > Cr-Commit-Position: refs/heads/master@{#30900}
    
    TBR=jarin@chromium.org,rossberg@chromium.org
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:4430
    
    Review URL: https://codereview.chromium.org/1360403002
    
    Cr-Commit-Position: refs/heads/master@{#30901}
    656ebdce
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...