• Michael Achenbach's avatar
    Revert "Fix "this" value in lazily-parsed module functions." · 62f09de9
    Michael Achenbach authored
    This reverts commit c3bd741e.
    
    Reason for revert: Breaks layout tests:
    https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/20384
    
    Original change's description:
    > Fix "this" value in lazily-parsed module functions.
    > 
    > When preparsing top-level functions in a module, we didn't track
    > unresolved variables. Consequently, "this" ended up referencing
    > the global "this", which has the wrong value (in a module "this"
    > is supposed to be the undefined value).
    > 
    > This patch fixes that. This also lets us stop forcing context
    > allocation of all variables in module scopes, which the patch
    > takes care of as well.
    > 
    > Bug: chromium:791334
    > Change-Id: Ifac1f1adc033f3facfb3d29dd4bca32ee27bffcf
    > Reviewed-on: https://chromium-review.googlesource.com/808938
    > Reviewed-by: Marja Hölttä <marja@chromium.org>
    > Reviewed-by: Adam Klein <adamk@chromium.org>
    > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    > Commit-Queue: Georg Neis <neis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#50025}
    
    TBR=adamk@chromium.org,marja@chromium.org,neis@chromium.org,kozyatinskiy@chromium.org
    
    Change-Id: I81f69334ed2ce104c00e6205d50001e4bdf07d15
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:791334
    Reviewed-on: https://chromium-review.googlesource.com/822258Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50036}
    62f09de9
Name
Last commit
Last update
..
OWNERS Loading commit data...
background-parsing-task.cc Loading commit data...
background-parsing-task.h Loading commit data...
duplicate-finder.h Loading commit data...
expression-classifier.h Loading commit data...
expression-scope-reparenter.cc Loading commit data...
expression-scope-reparenter.h Loading commit data...
func-name-inferrer.cc Loading commit data...
func-name-inferrer.h Loading commit data...
parse-info.cc Loading commit data...
parse-info.h Loading commit data...
parser-base.h Loading commit data...
parser.cc Loading commit data...
parser.h Loading commit data...
parsing.cc Loading commit data...
parsing.h Loading commit data...
pattern-rewriter.cc Loading commit data...
preparse-data-format.h Loading commit data...
preparse-data.cc Loading commit data...
preparse-data.h Loading commit data...
preparsed-scope-data.cc Loading commit data...
preparsed-scope-data.h Loading commit data...
preparser.cc Loading commit data...
preparser.h Loading commit data...
rewriter.cc Loading commit data...
rewriter.h Loading commit data...
scanner-character-streams.cc Loading commit data...
scanner-character-streams.h Loading commit data...
scanner.cc Loading commit data...
scanner.h Loading commit data...
token.cc Loading commit data...
token.h Loading commit data...