• Clemens Backes's avatar
    [liftoff] Fix illegal state updates in conditional tierup check · 8072d31a
    Clemens Backes authored
    The tier up check in br_if is only executed conditionally, so it is
    not allowed to update any cache state. Later code would work with that
    updated state, even though the corresponding code would not have
    executed.
    There was a partial implementation for this by passing in a scratch
    register for {TierupCheck}, but {TierupCheckOnExit} has the same
    problem, and needs up to three scratch registers.
    
    Until we come up with a better solution, just snapshot the cache state
    before doing the tier up check, and restore it later. This has some
    performance cost, but it's an effective fix.
    
    R=jkummerow@chromium.org
    
    Bug: chromium:1314184
    Change-Id: I1272010cc247b755e2f4d40615284a03ff8dadb6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3579363Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79896}
    8072d31a
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...