• Clemens Hammacher's avatar
    [cleanup] Fix (D)CHECK macros in src/{debug,inspector} · 8d38c15e
    Clemens Hammacher authored
    Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an
    embedded comparison. This gives better error messages and also does the
    right comparison for signed/unsigned mismatches.
    
    This will allow us to reenable the readability/check cpplint check.
    
    R=yangguo@chromium.org
    
    Bug: v8:6837
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I88e5afea1ad0fdf23a81b380e64ff356bbc20112
    Reviewed-on: https://chromium-review.googlesource.com/681374Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48138}
    8d38c15e
Name
Last commit
Last update
..
build Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
injected-script-source.js Loading commit data...
injected-script.cc Loading commit data...
injected-script.h Loading commit data...
injected_script_externs.js Loading commit data...
inspected-context.cc Loading commit data...
inspected-context.h Loading commit data...
inspector.gyp Loading commit data...
inspector.gypi Loading commit data...
inspector_protocol_config.json Loading commit data...
js_protocol-1.2.json Loading commit data...
js_protocol.json Loading commit data...
remote-object-id.cc Loading commit data...
remote-object-id.h Loading commit data...
script-breakpoint.h Loading commit data...
search-util.cc Loading commit data...
search-util.h Loading commit data...
string-16.cc Loading commit data...
string-16.h Loading commit data...
string-util.cc Loading commit data...
string-util.h Loading commit data...
test-interface.cc Loading commit data...
test-interface.h Loading commit data...
v8-console-agent-impl.cc Loading commit data...
v8-console-agent-impl.h Loading commit data...
v8-console-message.cc Loading commit data...
v8-console-message.h Loading commit data...
v8-console.cc Loading commit data...
v8-console.h Loading commit data...
v8-debugger-agent-impl.cc Loading commit data...
v8-debugger-agent-impl.h Loading commit data...
v8-debugger-script.cc Loading commit data...
v8-debugger-script.h Loading commit data...
v8-debugger.cc Loading commit data...
v8-debugger.h Loading commit data...
v8-function-call.cc Loading commit data...
v8-function-call.h Loading commit data...
v8-heap-profiler-agent-impl.cc Loading commit data...
v8-heap-profiler-agent-impl.h Loading commit data...
v8-injected-script-host.cc Loading commit data...
v8-injected-script-host.h Loading commit data...
v8-inspector-impl.cc Loading commit data...
v8-inspector-impl.h Loading commit data...
v8-inspector-session-impl.cc Loading commit data...
v8-inspector-session-impl.h Loading commit data...
v8-internal-value-type.cc Loading commit data...
v8-internal-value-type.h Loading commit data...
v8-profiler-agent-impl.cc Loading commit data...
v8-profiler-agent-impl.h Loading commit data...
v8-regex.cc Loading commit data...
v8-regex.h Loading commit data...
v8-runtime-agent-impl.cc Loading commit data...
v8-runtime-agent-impl.h Loading commit data...
v8-schema-agent-impl.cc Loading commit data...
v8-schema-agent-impl.h Loading commit data...
v8-stack-trace-impl.cc Loading commit data...
v8-stack-trace-impl.h Loading commit data...
v8-value-utils.cc Loading commit data...
v8-value-utils.h Loading commit data...
wasm-translation.cc Loading commit data...
wasm-translation.h Loading commit data...