• ahaas's avatar
    [turbofan] Don't call String::Flatten in Constant::ToHeapObject() · 5d8cfbbd
    ahaas authored
    The call to String::Flatten can cause garbage collection and in general adds
    complexity to the code generation. It also blocks the way to run code generation on worker threads.
    
    The call to String::Flatten in Constant::ToHeapObject() seems not to be necessary
    for correctness. If removing this call affects performance negatively, we can revert
    this CL.
    
    Review-Url: https://codereview.chromium.org/2107243002
    Cr-Commit-Position: refs/heads/master@{#37422}
    5d8cfbbd
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...